Skip to content

Conversation

Dylan-DPC-zz
Copy link

Successful merges:

Failed merges:

r? @ghost

petrochenkov and others added 8 commits February 24, 2020 21:46

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
resolve: `lifetimes.rs` -> `late/lifetimes.rs`

Lifetime resolution should ideally be merged into the late resolution pass, at least for named lifetimes.
Let's move it closer to it for a start.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
update llvm to silence gcc 9 warnings

Closes rust-lang#69078

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
clarify operator precedence

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
…lan-DPC

Clean up E0373 explanation

r? @Dylan-DPC
@Dylan-DPC-zz
Copy link
Author

@bors r+ rollup=never p=4

@bors
Copy link
Collaborator

bors commented Feb 26, 2020

📌 Commit 7f11fd0 has been approved by Dylan-DPC

@bors bors added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Feb 26, 2020
@Dylan-DPC-zz Dylan-DPC-zz added the rollup A PR which is a rollup label Feb 26, 2020
@bors
Copy link
Collaborator

bors commented Feb 27, 2020

⌛ Testing commit 7f11fd0 with merge 36156c9...

bors added a commit that referenced this pull request Feb 27, 2020
Rollup of 4 pull requests

Successful merges:

 - #69439 (resolve: `lifetimes.rs` -> `late/lifetimes.rs`)
 - #69473 (update llvm to silence gcc 9 warnings)
 - #69479 (clarify operator precedence)
 - #69480 (Clean up E0373 explanation)

Failed merges:

 - #69481 (use char instead of &str for single char patterns)
 - #69496 (use find(x) instead of filter(x).next())

r? @ghost
@bors
Copy link
Collaborator

bors commented Feb 27, 2020

💥 Test timed out

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Feb 27, 2020
@JohnTitor
Copy link
Member

Closing in favor of new rollup.

@JohnTitor JohnTitor closed this Feb 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
rollup A PR which is a rollup S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants